feat: Add Embedding Picker to Linear UI #3654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstein
requested review from
GreggHelt2,
JPPhoto,
StAlKeR7779,
damian0815 and
lstein
as code owners
lstein
requested changes
Jul 5, 2023
Collaborator
lstein
left a comment
lstein
left a comment
There was a problem hiding this comment.
Looks good and it works. Please review the changes I committed. In addition, there is a missing annotation type LoraModel in invokeai/backend/model_management/lora.py. I don't know where to find this.
invokeai/frontend/web/src/features/lora/components/ParamLora.tsx
Outdated
Show resolved
Hide resolved
- cursor reinserts at the end of the trigger - `enter` closes the select - popover styling
Contributor
|
@blessedcoolant ill defer to you for the internal changes in this PR, I'm not sure how to test them (not sure my TIs are actually working 😅 ) |
psychedelicious
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.