Fix inpaint node to new manager #3550
Conversation
StAlKeR7779
requested review from
GreggHelt2,
JPPhoto,
Kyle0654,
blessedcoolant,
damian0815 and
lstein
as code owners
|
The old txt2img and img2img are still used by canvas, pls do not delete |
psychedelicious
requested review from
maryhipp and
psychedelicious
as code owners
Instead of manually creating every node and edge, we can simply copy/paste the base graph from node editor, then sub in parameters. This is a much more intelligible process. We still need to handle seed, img2img fit and controlnet separately.
- Add graph builders for canvas txt2img & img2img - they are mostly copy and paste from the linear graph builders but different in a few ways that are very tricky to work around. Just made totally new functions for them. - Canvas txt2img and img2img support ControlNet (not inpaint/outpaint). There's no way to determine in real-time which mode the canvas is in just yet, so we cannot disable the ControlNet UI when the mode will be inpaint/outpaint - it will always display. It's possible to determine this in near-real-time, will add this at some point. - Canvas inpaint/outpaint migrated to use model loader, though inpaint/outpaint are still using the non-latents nodes.
psychedelicious
force-pushed
the
fix/inpaint_new_manager
branch
from
84794d8 to
41442eb
Compare
|
@blessedcoolant Everything should be working, including controlnet on canvas txt2img and img2img modes. Controlnet does not work on canvas inpaint/outpaint, but since we don't have real-time generation mode detection yet, we can't disable the controlnet UI when the mode is inpaint/outpaint. This will supersede the changes you made to add the model loader to the linear graph builders. |
Will give it a test run in a few. And I'll sync up the changes on the MM pr later. |
|
Tests need to be updated now that the |
Everything seems to be in order. @psychedelicious |
Inpaint node still used by canvas, so fixed it to new model manager api.
Other old generation code deleted.