ui: controlnet in linear ui #3491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I can verify that this PR fixes the problem with drag and drop of images in Chrome on Ubuntu. Huzzah! |
psychedelicious
force-pushed
the
feat/ui/controlnet-ui
branch
2 times, most recently
from
6c9cb45 to
b0be3c1
Compare
psychedelicious
requested review from
Kyle0654,
blessedcoolant,
ebr,
lstein and
maryhipp
as code owners
Contributor
And on chrome windows |
psychedelicious
force-pushed
the
feat/ui/controlnet-ui
branch
from
b0be3c1 to
959307f
Compare
blessedcoolant
approved these changes
Jun 4, 2023
Implement `dnd-kit` for image drag and drop - vastly simplifies logic bc we can drag and drop non-serializable data (like an `ImageDTO`) - also much prettier - also will fix conflicts with file upload via OS drag and drop, bc `dnd-kit` does not use native HTML drag and drop API - Implemented for Init image, controlnet, and node editor so far More progress on the ControlNet UI
For fast altering of the layout across all pre-preocessors.
psychedelicious
force-pushed
the
feat/ui/controlnet-ui
branch
from
959307f to
a676d35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ControlNet to the Linear UI (
Text to Image&Image to Imagetabs).miniUI displays the control image as a thumbnail, weight and begin/end step %advancedUI to see the control image much larger and access the processor settingsOther Changes
Enhanced drag and drop
dnd-kitfor drag and drop, much more capable than the previous implementation with native HTML Drag and Drop APIIAIDndImagecomponent encapsulates logic for draggable and droppable imagesMisc
accentAlpha.200,okAlpha.700TODO: