Default Scheduler Update #3457
Merged
Default Scheduler Update #3457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipsterusername
requested review from
Kyle0654,
blessedcoolant and
psychedelicious
as code owners
psychedelicious
approved these changes
May 24, 2023
Collaborator
|
Why Euler and not Euler_A ..? I feel that one converges fast and performs better in general at 20 steps on most models. |
Member
Author
|
Euler_a is quite different from other schedulers in output though. I'm not strongly opposed, just don't think it's "standard/default" |
Collaborator
|
I'm good with either. Mostly saw euler_a used pretty commonly. It's a one time swap for most people anyway. |
blessedcoolant
approved these changes
May 25, 2023
hipsterusername
force-pushed
the
change_default_scheduler
branch
from
cc00078 to
25015fa
Compare
psychedelicious
force-pushed
the
change_default_scheduler
branch
from
25015fa to
7569030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing updating from lms as default scheduler, given its tendency to produce odd results as of late.