Skip to content

[Bugfix] fixes and code cleanup to update and installation routines #3101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 25, 2023
Merged

[Bugfix] fixes and code cleanup to update and installation routines #3101

merged 4 commits into from
Apr 25, 2023

Conversation

@lstein
Copy link
Collaborator

@lstein lstein commented Apr 2, 2023 •
edited
Loading

  • Fix the update script to work again and fixes the ambiguity between when a user wants to update to a tag vs updating to a branch, by making these two operations explicitly separate.
  • Remove dangling functions and arguments related to legacy checkpoint conversion. These are no longer needed now that all legacy models are either converted at import time, or on-the-fly in RAM.

@lstein
fix invokeai-update script
f682fb8 
- This commit fixes the update script to work again, as well as fixing
  the ambiguity between updating to a tag and updating to a branch.
@lstein lstein changed the title [Bugfix] make update script work again [Bugfix] fixes and code cleanup to update and installation routines Apr 2, 2023
@lstein lstein force-pushed the bugfix/release-updater branch from 85a672a to f682fb8 Compare April 5, 2023 21:24
ebr
ebr approved these changes Apr 16, 2023
View reviewed changes
Copy link
Contributor

@ebr ebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these changes are already in main?
Approving anyway.

@lstein lstein merged commit c174cab into main Apr 25, 2023
@lstein lstein deleted the bugfix/release-updater branch April 25, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mauwii mauwii Awaiting requested review from mauwii

@keturn keturn Awaiting requested review from keturn

@damian0815 damian0815 Awaiting requested review from damian0815

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

2 more reviewers

@ebr ebr ebr approved these changes

@JPPhoto JPPhoto JPPhoto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lstein @ebr @JPPhoto