Skip to content

Conversation

@Kyle0654
Copy link
Contributor

@Kyle0654 Kyle0654 commented Apr 1, 2023

Adds latent nodes for text to latent and latent to latent (roughly equivalent to text to image and image to image).
Adds latent storage.
Adds simple math nodes.
Fix bug in iteration expansion that was causing incorrect edges.
Add simple range and random range collection generator nodes.
Fix bug in CLI when linking to multiple nodes.

Example of new nodes:

random_range --size 3 | iterate | noise --link -1 item seed | t2l --prompt "banana sushi" | l2i | show_image

Generates 3 different images.

@Kyle0654 Kyle0654 requested a review from blessedcoolant as a code owner April 1, 2023 02:45
@damian0815
Copy link
Contributor

i paid most attention to latent.py. my only real issue is the naming of latent as I wrote in the comment above. otherwise it looks good.

@damian0815
Copy link
Contributor

thanks for the latents rename - i've marked this as good (haven't tested running it though)

@lstein
Copy link
Collaborator

lstein commented Apr 3, 2023 via email

@Kyle0654
Copy link
Contributor Author

Kyle0654 commented Apr 4, 2023

@lstein if we get this merged, could you later add something to model manager to get just the vae (in a cache-friendly way) and update LatentsToImage to use that?

Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the graph plotting in the CLI.

@lstein
Copy link
Collaborator

lstein commented Apr 4, 2023

Sure.

Kyle0654 added 5 commits April 5, 2023 11:29
Add collection nodes, math nodes.
Add noise node.
Add some graph debug commands to the CLI.
Fix negative id linking in CLI.
Fix a CLI bug with multiple links per node
@Kyle0654 Kyle0654 force-pushed the kyle0654/node_latents branch from 195fa70 to cd03df9 Compare April 5, 2023 18:29
@Kyle0654 Kyle0654 enabled auto-merge (squash) April 5, 2023 19:40
@lstein
Copy link
Collaborator

lstein commented Apr 5, 2023

@lstein if we get this merged, could you later add something to model manager to get just the vae (in a cache-friendly way) and update LatentsToImage to use that?

The model manager part of this request is now in PR #3120. As soon as both this PR and that one are merged with main I'll updateLatentsToImage.

@Kyle0654 Kyle0654 merged commit 85b020f into main Apr 6, 2023
@Kyle0654 Kyle0654 deleted the kyle0654/node_latents branch April 6, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants