Add support for yet another TI embedding format (main version) #3050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This PR adds support for embedding files that contain a single key "emb_params". The only example I know of this format is the "EasyNegative" embedding on HuggingFace, but there are certainly others. - This PR also adds support for loading embedding files that have been saved in safetensors format. - It also cleans up the code so that the logic of probing for and selecting the right format parser is clear.
lstein
requested review from
JPPhoto,
blessedcoolant,
damian0815 and
keturn
as code owners
lstein
changed the title
JPPhoto
approved these changes
Mar 27, 2023
damian0815
suggested changes
Mar 28, 2023
damian0815
approved these changes
Mar 30, 2023
Contributor
There was a problem hiding this comment.
looks good - with a small nitpick, having read the last version of textual_inversion_manager.py i think EmbeddingInfo would better be named ParsedEmbeddingInfo and also its definition ought to go beneath TextualInversionInfo - or better, it ought to be a subclass of TextualInversionManager itself (can't recall if that works in python). otherwise its scope/purpose, as a utility class that only exists transitionally, is unclear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for embedding files that contain a single key "emb_params". The only example I know of this format is the "EasyNegative" embedding on HuggingFace, but there are certainly others.
This PR also adds support for loading embedding files that have been saved in safetensors format.
It also cleans up the code so that the logic of probing for and selecting the right format parser is clear.
This is the same as Add support for yet another TI embedding file format (2.3 version) #3045, which is on the 2.3 branch.