Skip to content

Conversation

@JPPhoto
Copy link
Contributor

@JPPhoto JPPhoto commented Mar 6, 2023

Fixed an import statement for the web UI server.
Fixed the new run_patches() function to create destination directories if they don't exist.

@psychedelicious
Copy link
Contributor

This is a duplicate of #2875

@blessedcoolant
Copy link
Collaborator

I fixed the import issue in #2875 but yours has another fix that needs to be made too. I will close my PR. Wouldn't it be better to import from invokeai.frontend.merge rather than going relative?

Either works but just wondering. Closing my PR.

Copy link
Contributor

@keturn keturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model merging works w/ this change, ty

@JPPhoto JPPhoto enabled auto-merge (squash) March 6, 2023 20:39
@JPPhoto
Copy link
Contributor Author

JPPhoto commented Mar 6, 2023

Wouldn't it be better to import from invokeai.frontend.merge rather than going relative?

@blessedcoolant It seemed that everything else in this file used relative syntax so I copied the pattern.

@blessedcoolant
Copy link
Collaborator

Wouldn't it be better to import from invokeai.frontend.merge rather than going relative?

@blessedcoolant It seemed that everything else in this file used relative syntax so I copied the pattern.

All good. Guess this needs a review from @lstein before it is mergeable.

Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing these problems.

@JPPhoto JPPhoto merged commit c3ff9e6 into main Mar 6, 2023
@JPPhoto JPPhoto deleted the JPPhoto-fix-startup branch March 6, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants