feat(ui): migrate theming to chakra ui #2873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
lstein and
mauwii
as code owners
|
The mobile UI no longer reflows to single column with this change. Is that intentional? |
mauwii
approved these changes
Mar 6, 2023
blessedcoolant
approved these changes
Mar 6, 2023
Contributor
Author
|
@neecapp yes, insofar as this is the unstable main branch you are on. User-facing release is on branch v2.3 while we doing some major works on main. Need to redo the responsive design stuff still. |
|
👍 Yes, I know. Just wondering, since there wasn't any mention of future work or things that were intentionally not addressed that will have follow-on work in the original PR description. |
Contributor
Author
|
@neecapp sorry, you're right, should have mentioned this as a breaking change. will get it re-implemented soon, maybe tonight. |
blessedcoolant
added a commit
that referenced
this pull request
Mar 12, 2023
wip this is based off the branch in #2873
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks like this #2814 was reverted accidentally. instead of trying to revert the revert, this PR can simply be re-accepted and will fix the ui.
To test this PR in dev mode, you will need to do a
yarn installas a lot has changed.thanks to @blessedcoolant for helping out on this, it was a big effort.