Skip to content

Conversation

@mastercaster9000
Copy link
Contributor

Bit of basic housekeeping and documentation to explain to people how to get local development environment running (including the tests).

@mauwii
Copy link
Contributor

mauwii commented Mar 5, 2023

There are already docs in the pipes which can be found here 🙈

@mastercaster9000
Copy link
Contributor Author

Ah my bad, had missed the docs - discussion on discord last night indicated a few people weren't aware of how to run the tests. Feel free to ignore that commit then. 🤦

Copy link
Contributor

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted a couple small spelling mistakes and converted in the web section.

Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and I very much appreciate the doc enhancements.

@lstein
Copy link
Collaborator

lstein commented Mar 6, 2023

There are already docs in the pipes which can be found here see_no_evil

The two docs are actually quite complementary, and I note that the docs/help/contributing docs are found in the v2.3 branch and not main. I suggest that we accept this PR into main, do an integration into the docs/help/contributing files in v2.3, and then synchronize back into v2.3

@mauwii, am I correct in thinking that the mkdocs site always reflects the latest release? If this plan is acceptable, we should aim to get this done by the end of the week.

Copy link
Contributor

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My requested changes were addressed, thanks!

@hipsterusername
Copy link
Member

@lstein Aside from addressing conflicts, anything needed to merge this in?

@lstein lstein enabled auto-merge March 24, 2023 03:22
@lstein lstein merged commit 1ba1076 into invoke-ai:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants