Skip to content

Conversation

@keturn
Copy link
Contributor

@keturn keturn commented Mar 5, 2023

Things to check for in this version:

  • diffusers cache location is now more consistent with other huggingface-hub using code (i.e. transformers) as of Use "hub" directory for cache instead of "diffusers" huggingface/diffusers#2005. I think ultimately this should make @damian0815 (and other folks with multiple diffusers-using projects) happier, but it's worth taking a look to make sure the way @lstein set things up to respect HF_HOME is still functioning as intended.
  • I've gone ahead and updated transformers to the current version (4.26), but I have a vague memory that we were holding it back at some point? Need to look that up and see if that's the case and why.

@keturn
Copy link
Contributor Author

keturn commented Mar 5, 2023

I've run pytest + preflight_prompts here on Linux/nvidia (with and without --xformers) and that much checks out fine.

@lstein lstein merged commit 7cf2f58 into main Mar 5, 2023
@lstein lstein deleted the dev/diffusers014 branch March 5, 2023 06:53
Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and merged. The HF_HOME environment variable is still working as intended, but someone (me?) is going to have to write a migration routine that does a one-time transfer of everything in the HF_HOME/diffusers directory to HF_HOME/hub. Otherwise we're going to have duplicate files in hub and diffusers. It's possible that the migration mechanism that's already in diffusers will do that for us.... ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants