fix(firestore): remove inequality filter with orderBy limitation

[JiriHoffmann]

Description

This PR removes a query modifiers check that is no longer necessary. This check is preventing inequality filters from being combined with orderBy filters if they are applied to a different field.

Related issues

• Fixes [🐛] Cannot execute query with inequality operator and orderBy different field #8534
• Fixes [🐛] 🔥 Query validation may be overly restrictive for inequality filters #8161

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
  • Other (macOS, web)
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

🔥

[vercel]

@JiriHoffmann is attempting to deploy a commit to the Invertase Team on Vercel.

A member of the Team first needs to authorize it.

[mikehardy]

Thanks for this! Really appreciated. The testing, specifically, is great to see

This limit did exist at one point but I verified that in the current set of orderBy limitations the only thing remaining is that it will filter out / only return docs where the orderBy key exists

https://firebase.google.com/docs/firestore/query-data/order-limit-data#limitations
https://firebase.google.com/docs/firestore/query-data/queries#query_limitations
https://firebase.google.com/docs/firestore/query-data/queries#orderby_and_existence