fix(ios): use 'note' for info messages in Xcode scripts #8734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
info has no semantic meaning in Xcode build scripts, so they were not printed. But note does (as does error and warning, which were used correctly)
mikehardy
force-pushed
the
@mikehardy/ios-config-info-printouts
branch
from
4955d78 to
cf5a466
Compare
mikehardy
force-pushed
the
@mikehardy/ios-config-info-printouts
branch
from
d050092 to
da9fd78
Compare
de-lints the file and solves a problem where locally you cannot test the script if you have built both the release and debug version
previously I was confusing onConfigUpdate with onConfigUpdated... that 'd'
there were severe performance problems with remote-config testing on iPhone 17 + macos-26 + Xcode 26, perhaps this will help
mikehardy
force-pushed
the
@mikehardy/ios-config-info-printouts
branch
from
da9fd78 to
8679bd2
Compare
Collaborator
Author
|
Had a really difficult time getting iOS e2e to run successfully and even now it's a bit flaky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today I learned (while updating react-native-google-mobile-ads):
info has no semantic meaning in Xcode build scripts, so they were not printed. But note does (as does error and warning, which were used correctly)
https://developer.apple.com/documentation/xcode/running-custom-scripts-during-a-build#Log-errors-and-warnings-from-your-script
Release Summary
semantic release, single fix commit
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Search the build logs for
RNFB build scriptand you should see it now. Before the build script was not logging any of it's useful informationThink
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter