Skip to content

Conversation

@tad3j
Copy link
Contributor

@tad3j tad3j commented Sep 11, 2020

According to FirebaseAnalyticsTypes logSelectContent() and logEvent() are async functions.

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

According to `FirebaseAnalyticsTypes` `logSelectContent()` and  `logEvent()` are async functions.
@CLAassistant
Copy link

CLAassistant commented Sep 11, 2020

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Sep 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/3q481uc7d
✅ Preview: https://react-native-firebase-git-fork-tad3j-patch-2.invertase.vercel.app

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @tad3j ! just need the cla signed and can merge

@tad3j
Copy link
Contributor Author

tad3j commented Sep 11, 2020

good catch @tad3j ! just need the cla signed and can merge

Done.

@mikehardy mikehardy merged commit cfa56bd into invertase:master Sep 12, 2020
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants