Skip to content

Conversation

@igdianov
Copy link
Collaborator

@igdianov igdianov commented Sep 5, 2020

This PR adds support for parsing and serializing Timestamp scalar value, i.e.

  • Epoch time in milliseconds
  • ISO Instant
  • ISO Offset Date/Time
  • ISO Zoned Date/Time
  • ISO Local Date/Time
  • ISO Local Date

The output of serialize is a string in ISO 8086 Date/Time in UTC time zone, i.e. "2019-08-05T07:15:07Z"

The output of parseValue and parseLiteral is java.sql Timestamp value in UTC time zone.

@igdianov igdianov self-assigned this Sep 5, 2020
@codecov
Copy link

codecov bot commented Sep 5, 2020

Codecov Report

Merging #283 into master will increase coverage by 0.50%.
The diff coverage is 94.64%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #283      +/-   ##
============================================
+ Coverage     74.08%   74.58%   +0.50%     
+ Complexity     1072     1071       -1     
============================================
  Files            72       72              
  Lines          4765     4801      +36     
  Branches        681      683       +2     
============================================
+ Hits           3530     3581      +51     
+ Misses          929      912      -17     
- Partials        306      308       +2     
Impacted Files Coverage Δ Complexity Δ
...ventures/graphql/jpa/query/schema/JavaScalars.java 57.80% <94.64%> (+10.38%) 6.00 <0.00> (ø)
.../graphql/jpa/query/introspection/Constructors.java 78.00% <0.00%> (-4.00%) 14.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65307a9...9177545. Read the comment docs.

@igdianov igdianov merged commit 105c8dc into master Sep 11, 2020
@igdianov igdianov deleted the fix-timestamp branch September 11, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants