Skip to content

Conversation

@igdianov
Copy link
Collaborator

@igdianov igdianov commented Apr 8, 2020

This PR adds support to enable/disable default max result size query pagination via GraphQLJpaSchemaBuilder.enableDefaultMaxResultSize(boolean) feature toggle. This feature is enabled by default.

Fixes #253

@igdianov igdianov self-assigned this Apr 8, 2020
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #254 into master will decrease coverage by 0.09%.
The diff coverage is 40.62%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #254      +/-   ##
============================================
- Coverage     72.34%   72.24%   -0.10%     
- Complexity     1027     1028       +1     
============================================
  Files            71       71              
  Lines          4672     4688      +16     
  Branches        670      670              
============================================
+ Hits           3380     3387       +7     
- Misses         1005     1013       +8     
- Partials        287      288       +1     
Impacted Files Coverage Δ Complexity Δ
...query/schema/relay/GraphQLJpaRelayDataFetcher.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...jpa/query/schema/impl/GraphQLJpaSchemaBuilder.java 88.65% <33.33%> (-0.44%) 127.00 <0.00> (ø)
.../query/schema/impl/GraphQLJpaQueryDataFetcher.java 90.00% <87.50%> (-1.67%) 7.00 <0.00> (ø)
...a/query/schema/impl/GraphQLJpaExecutorContext.java 97.91% <100.00%> (+0.09%) 11.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc3e57...7ead02c. Read the comment docs.

@igdianov igdianov merged commit 1297e68 into master Apr 8, 2020
@igdianov igdianov deleted the fix-enable-default-max-results branch April 8, 2020 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support enable/disable default max result size query pagination

2 participants