Testing and metadata for Ch02 #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonathan-taylor please test Ch02. Clone this repo, checkout the branch testing, do “make Jupyter” (fast!) and visit Ch02. There are 3 suspicious cells. I changed their metadata (View => Property Inspector => Advanced Tools) |
|
@tschm I really haven't forgotten this and other pull requests. Thanks for the work! I am finishing a big undergrad course this week and will have time to turn to ISLP very soon. |
|
If you want we can fix a time for a zoom call and we can merge together. I am still 12h ahead of you :-) |
|
Before merging this, please address #36 |
|
I see you added a tag. I see that this going to be ignored by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should be all green now?