Improve display of preview on pull page #749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
==========================================
+ Coverage 41.30% 41.39% +0.09%
==========================================
Files 24 24
Lines 3213 3213
==========================================
+ Hits 1327 1330 +3
+ Misses 1886 1883 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
isc-pbarton
force-pushed
the
improve-pull-display
branch
from
fca9e96 to
4ff2cd2
Compare
isc-tleavitt
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #740
If there are a lot of changes in the pull preview, it can take up the full page. The scrolling behavior with pre tags is not super intuitive. Adding a max height to the preview makes it easier to see the results.