Provide installation type as settings attribute #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harkin
previously approved these changes
Feb 12, 2024
dkremez
force-pushed
the
dkremez/set-installation-type-on-boot
branch
from
4665a0c to
ef3275b
Compare
dkremez
force-pushed
the
dkremez/set-installation-type-on-boot
branch
2 times, most recently
from
e39f36b to
1993c22
Compare
harkin
reviewed
Feb 12, 2024
harkin
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Towards https://github.com/intercom/intercom/issues/322688
We want to better understand how people usually install our messenger. For that reason on all non snippet installations we set
installation_typesettings attribute that will provide that information.Evidence