fix(gateway,component): SelectMenu parse per SelectOption #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@DeltaXWizard look at pr pls 👀 |
FayeDel
requested changes
Jan 13, 2022
Comment on lines
+323
to
+324
| if context.data._json.get("values"): | ||
| _args.append(context.data.values) |
Collaborator
There was a problem hiding this comment.
The PR looks good to me,
but I want to know the reason behind the add values in message component detail, over simply just using context object as how it was in v3's callbacks
Contributor
Author
There was a problem hiding this comment.
Because in the callback function it will be much easier to immediately receive the selected value than to request it from nowhere (I, for example, did not immediately understand that the value can be obtained from the context).
EepyElvyra
suggested changes
Jan 16, 2022
Contributor
EepyElvyra
left a comment
EepyElvyra
left a comment
There was a problem hiding this comment.
You got a merge conflict
i0bs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull request is about (X), which does (Y).
fix SelectMenu
add values in message_component
pre-committo format and lint the change(s) made.3.8.6and higher.