Skip to content

fix(gateway,component): SelectMenu parse per SelectOption #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 20, 2022
Merged

fix(gateway,component): SelectMenu parse per SelectOption #423

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
22e6ad3
(f) fix SelectMenu and addition add values in message component
MeidoNoHitsuji Jan 11, 2022
04461ed
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 11, 2022
4e14c9c
Merge branch 'goverfl0w:unstable' into unstable
MeidoNoHitsuji Jan 13, 2022
1985653
(f) fix check_sub_auto
MeidoNoHitsuji Jan 13, 2022
5b66269
Merge branch 'unstable' into unstable
MeidoNoHitsuji Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions interactions/api/gateway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,8 @@ def check_sub_auto(option: dict) -> tuple:
)
elif data["type"] == InteractionType.MESSAGE_COMPONENT:
_name = f"component_{context.data.custom_id}"
if context.data._json.get("values"):
_args.append(context.data.values)
Comment on lines +317 to +318
Copy link
Collaborator

@FayeDel FayeDel Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me,
but I want to know the reason behind the add values in message component detail, over simply just using context object as how it was in v3's callbacks

Copy link
Contributor Author

@MeidoNoHitsuji MeidoNoHitsuji Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because in the callback function it will be much easier to immediately receive the selected value than to request it from nowhere (I, for example, did not immediately understand that the value can be obtained from the context).

elif data["type"] == InteractionType.APPLICATION_COMMAND_AUTOCOMPLETE:
_name = f"autocomplete_{context.data.id}"
if context.data._json.get("options"):
Expand Down
2 changes: 2 additions & 0 deletions interactions/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,8 @@ async def send(
for component in components.components
]
elif isinstance(components, (Button, SelectMenu)):
if isinstance(components, SelectMenu):
components._json["options"] = [option._json for option in components.options]
_components[0]["components"] = (
[components._json]
if components._json.get("custom_id") or components._json.get("url")
Expand Down
12 changes: 8 additions & 4 deletions interactions/models/component.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,14 @@ def __init__(self, **kwargs) -> None:
super().__init__(**kwargs)
self.type = ComponentType.SELECT
self.options = (
SelectOption(**option)
if not isinstance(option, SelectOption)
else self._json.get("options")
for option in self.options
[
SelectOption(**option._json)
if isinstance(option, SelectOption)
else SelectOption(**option)
for option in self.options
]
if self._json.get("options")
else None
)
self._json.update({"type": self.type.value})

Expand Down