Skip to content

fix: Remove empty _client attribute in _json property #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2022
Merged

fix: Remove empty _client attribute in _json property #999

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60d8a82
fix: Remove empty _client attribute in _json property
FayeDel Aug 3, 2022
7389fdb
refactor: conditional logic
FayeDel Aug 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions interactions/api/models/attrs_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,18 @@ def __init__(self, kwargs_dict: dict = None, /, **other_kwargs):

if (value := kwargs.pop(discord_name, MISSING)) is not MISSING:
if value is not None and attrib.metadata.get("add_client"):
if isinstance(value, list):
for item in value:
if isinstance(item, dict):
item["_client"] = client
elif isinstance(item, DictSerializerMixin):
item._client = client
else:
if isinstance(value, dict):
value["_client"] = client
elif isinstance(value, DictSerializerMixin):
value._client = client
if client is not None:
if isinstance(value, list):
for item in value:
if isinstance(item, dict):
item["_client"] = client
elif isinstance(item, DictSerializerMixin):
item._client = client
else:
if isinstance(value, dict):
value["_client"] = client
elif isinstance(value, DictSerializerMixin):
value._client = client

# make sure json is recursively handled
if isinstance(value, list):
Expand Down