Skip to content

Refactor: change logging level to warning for not dispatchable events #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 24, 2022
Merged

Refactor: change logging level to warning for not dispatchable events #968

merged 4 commits into from
Jul 24, 2022

Conversation

@athyk
Copy link
Contributor

@athyk athyk commented Jul 24, 2022

About

This pull request changes .fatal to .warning. This allows suppression if you have non existent functions to handle these events.

Before:

CRITICAL:gateway:An error occured dispatching voice_state_update: module 'interactions' has no attribute 'VoiceState'
CRITICAL:gateway:An error occured dispatching voice_state_update: module 'interactions' has no attribute 'VoiceState'

After:

WARNING:gateway:An error occured dispatching voice_state_update: module 'interactions' has no attribute 'VoiceState'
WARNING:gateway:An error occured dispatching voice_state_update: module 'interactions' has no attribute 'VoiceState'

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

EepyElvyra
EepyElvyra suggested changes Jul 24, 2022
View reviewed changes
Copy link
Contributor

@EepyElvyra EepyElvyra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a convenientonal commit scope and pr title

@Damego
Copy link
Member

Damego commented Jul 24, 2022

Also change branch to unstable

@athyk athyk changed the title Update client.py Allow suppression of non existent events Jul 24, 2022
@EepyElvyra EepyElvyra changed the title Allow suppression of non existent events Refactor: Allow suppression of non existent events Jul 24, 2022
@athyk athyk changed the base branch from stable to unstable July 24, 2022 16:04
@athyk athyk requested a review from EepyElvyra July 24, 2022 16:36
@EepyElvyra EepyElvyra enabled auto-merge (squash) July 24, 2022 16:38
@EepyElvyra EepyElvyra changed the title Refactor: Allow suppression of non existent events Refactor: change logging level to warning for not dispatchable events Jul 24, 2022
@EepyElvyra EepyElvyra merged commit d1fbb39 into interactions-py:unstable Jul 24, 2022
@EepyElvyra
Copy link
Contributor

EepyElvyra commented Jul 24, 2022

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@EepyElvyra EepyElvyra EepyElvyra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@athyk @Damego @EepyElvyra @FayeDel