Skip to content

Conversation

@quirky-bluejay
Copy link
Contributor

About this pull request

Adds a call to SlashCommandOptionType.from_type if the type passed was not an int

Changes

  • Restructure SlashCommandOptionType.from_type because currently if bool is passed it will return the value for an integer (this is because bool is a subclass of integer)
  • Adds a call to SlashCommandOptionType.from_type if the type passed was not an int
  • Adds an error IncorrectType which is raised if from_type doesn't return anything

Checklist

@eunwoo1104 eunwoo1104 self-requested a review February 3, 2021 13:34
@eunwoo1104 eunwoo1104 self-assigned this Feb 3, 2021
@eunwoo1104
Copy link
Contributor

Well looks like the issue is resolved now. Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants