Skip to content

feat: Implement barebones Select Menus for other supporting types #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 13, 2022
Merged

feat: Implement barebones Select Menus for other supporting types #836

merged 11 commits into from
Oct 13, 2022

Conversation

@FayeDel
Copy link
Collaborator

@FayeDel FayeDel commented Jun 9, 2022

About

This pull request adds compatibility with other types of Select Menus, with type-conversion arg support.

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@FayeDel FayeDel added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 9, 2022
@FayeDel FayeDel self-assigned this Jun 9, 2022
@FayeDel FayeDel marked this pull request as draft June 9, 2022 22:29
@FayeDel FayeDel removed their assignment Jun 9, 2022
FayeDel and others added 10 commits June 23, 2022 08:44
@FayeDel
fix: Tweak SelectMenu option generation for other type of menus
a1bebc1
@FayeDel
Merge pull request interactions-py#959 from interactions-py/unstable
e636d4e 
chore: merge unstable into stable for pre-release 1
@FayeDel
Merge pull request interactions-py#985 from interactions-py/unstable
53407b1 
chore: Merge unstable to stable
@FayeDel
Merge pull request interactions-py#1001 from interactions-py/unstable
7819ffc 
chore: merge unstable into stable
@Damego
docs: update FAQ and quickstart documentation links (interactions-py#…
0c6f59b 
…1038)

* Docs: add back previous changes

* docs: fix outdated links in the quickstart (interactions-py#1037)

Co-authored-by: Damego <[email protected]>
@FayeDel
Merge pull request interactions-py#1031 from interactions-py/unstable
348def8 
chore: merge unstable into stable
@FayeDel
Merge pull request interactions-py#1085 from interactions-py/unstable
b70033b 
chore: Merge unstable to stable
@FayeDel
Merge pull request interactions-py#1095 from interactions-py/unstable
838330d 
chore: merge unstable into stable
@FayeDel
Merge branch 'master' into unstable-undoc-menus-2
0df7ea8 
# Conflicts:
#	interactions/api/gateway/client.py
#	interactions/api/gateway/client.pyi
@FayeDel
chore: Resolve merge conflicts.
87b52f4
@FayeDel
Copy link
Collaborator Author

FayeDel commented Oct 13, 2022

Marking this as ready to review as its rebased + the feature is now live

@FayeDel FayeDel marked this pull request as ready for review October 13, 2022 22:34
@FayeDel FayeDel enabled auto-merge (squash) October 13, 2022 22:34
EepyElvyra
EepyElvyra approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@EepyElvyra EepyElvyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@FayeDel FayeDel merged commit d048a8c into interactions-py:unstable Oct 13, 2022
@FayeDel FayeDel mentioned this pull request Oct 15, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@EepyElvyra EepyElvyra EepyElvyra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FayeDel @EepyElvyra