Skip to content

feat: Implement barebones Server Subscriptions support. #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 8, 2022
Merged

feat: Implement barebones Server Subscriptions support. #767

merged 7 commits into from
Dec 8, 2022

Conversation

@FayeDel
Copy link
Collaborator

@FayeDel FayeDel commented Apr 28, 2022 •
edited
Loading

About

This PR title essentially explains itself.

Server Subscriptions, formerly Premium Membership, have been released widespread towards all community-based servers that resides in the US, hence the ready-to-review PR.

This correlates to an earlier PR: #630

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@FayeDel FayeDel added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 28, 2022
@FayeDel FayeDel marked this pull request as draft April 28, 2022 01:54
@FayeDel FayeDel mentioned this pull request Apr 28, 2022
Closed
7 tasks
@FayeDel FayeDel changed the title docs, feat: Implement barebones Premium Membership support. feat: Implement barebones Premium Membership support. May 5, 2022
@i0bs
Copy link
Contributor

i0bs commented Jul 11, 2022

Premium memberships now offer information on multiple subscriptions present on a guild member. See here for more.

@FayeDel
Copy link
Collaborator Author

FayeDel commented Dec 2, 2022

Marking this ready to review only because the feature's live;
(This PR still needs to be updated to latest unstable however)

@FayeDel FayeDel marked this pull request as ready for review December 2, 2022 17:01
i0bs
i0bs reviewed Dec 2, 2022
View reviewed changes
@FayeDel FayeDel force-pushed the unstable-undoc-membership branch from 252f067 to d62d111 Compare December 6, 2022 20:29
@FayeDel FayeDel enabled auto-merge (squash) December 6, 2022 20:48
@FayeDel FayeDel changed the title feat: Implement barebones Premium Membership support. feat: Implement barebones Server Subscriptions support. Dec 6, 2022
Damego
Damego reviewed Dec 8, 2022
View reviewed changes
Damego
Damego reviewed Dec 8, 2022
View reviewed changes
@FayeDel
docs, feat: Include server-subscriptions related error codes, enums, …
18b1b78 
…and proper nomenclature.

(according to discord-api-docs, ebebc249cbe817c0927b17189b533f4d60715961)
Damego
Damego approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@Damego Damego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@FayeDel FayeDel merged commit a9e97ca into interactions-py:unstable Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Damego Damego Damego approved these changes

+1 more reviewer

@i0bs i0bs i0bs left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FayeDel @i0bs @Damego