fix: check for WS_CLOSED_MESSAGE after receiving #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EepyElvyra
approved these changes
Mar 26, 2022
Contributor
EepyElvyra
left a comment
EepyElvyra
left a comment
There was a problem hiding this comment.
LGTM. similar approach also working on the voice Websocket, I'm assuming the same behavior here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull request is about the gateway. It makes sure the packet isn't a WS_CLOSED_MESSAGE before trying to receive packets. Previously, the lib attempted to continuously receive packets even though they were all WS_CLOSED_MESSAGE.
Checklist
pre-committo format and lint the change(s) made.3.8.6and higher.