Skip to content

fix: add banner_color to User model #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 6, 2022
Merged

fix: add banner_color to User model #612

merged 4 commits into from
Mar 6, 2022

Conversation

@kyteware
Copy link
Contributor

@kyteware kyteware commented Mar 2, 2022 •
edited
Loading

Added banner_color to User model (slots and docstring)

About

This pull request is about the undocumented banner_color user attribute, which is for user banners..

Checklist

@kyteware
fix: add banner_color to User model
11f571a 
added to __slots__ and to docstring
@kyteware kyteware marked this pull request as ready for review March 2, 2022 06:56
@kyteware
Copy link
Contributor Author

kyteware commented Mar 2, 2022

frick i opened on accident

i0bs
i0bs suggested changes Mar 2, 2022
View reviewed changes
@i0bs i0bs enabled auto-merge (squash) March 2, 2022 06:57
@i0bs i0bs added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Mar 2, 2022
@i0bs i0bs linked an issue Mar 2, 2022 that may be closed by this pull request
[BUG] The user model does not currently contain support for a banner_color attribute #607
Closed
1 task
auto-merge was automatically disabled March 2, 2022 15:32

Head branch was pushed to by a user without write access

kyteware
kyteware commented Mar 2, 2022
View reviewed changes
Copy link
Contributor Author

@kyteware kyteware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(wtf was i doing lmao)

@EepyElvyra EepyElvyra merged commit 31551b9 into interactions-py:unstable Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@i0bs i0bs i0bs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Projects

core
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] The user model does not currently contain support for a banner_color attribute

3 participants

@kyteware @i0bs @EepyElvyra