-
Notifications
You must be signed in to change notification settings - Fork 185
refactor: Logger parse structure #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Personally, I think that Warning, Error, and Critical should be shown if it directly relates to the user So (as examples) a duplicate command should warning/error to stderr, but the critical from missing attributes shouldn't be shown |
I agree. I suppose NullHandlers would be a bad idea as default then. The missing attribute warning spam gets somewhat irritating, and confusing for some as well. Maybe we can pass errors and critical? |
|
e500293 should allow errors, but still give users the ability to define a Tested |
EepyElvyra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except those two smaller issues this looks fine to me
Thanks, missed those two |
no problem |
EepyElvyra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
I'm willing to include this as a refactor instead of a feature commit, but there's a merge conflict stopping me from doing that. |
|
Alright I'll try to get that resolved today |
… into fix-logging-v4
|
Merged unstable, I don't see merge conflicts anymore, but let me know if there's still something wrong |
|
Would recommend running |
|
This PR LGTM. Thank you for contributing to the library for the first time, and welcome to the contributors club. 😃 |
About
Related to #421
Unless a simple logging configuration is setup, log messages should be hidden.Users can set the level withlogging.basicConfig(level=logging.DEBUG)ex. if they desire.interactionsshould then propagate its loggers to that StreamHandlerA list of loggers (their names) is present in
base.Datawhich gets populated after importinginteractionsChecklist
pre-committo format and lint the change(s) made.3.8.6and higher.