fix: fail loudly if extension classes are named the same #1618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Currently, loading two extensions that have the same class name causes subtle bugs to occur, which eventually culminates in
reload_extension
and other parts of code to error out in a confusing way (it literally took a whole year of discussion in the help forums to find this, as a refernece). Whileinteractions.py
should be able to handle extensions like this, making that work would require breaking changes, so failing loudly is a preferable solution here.This PR does just that.
Changes
Related Issues
Test Scenarios
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files