Skip to content

fix: add application_id to ApplicationCommandPermissionsUpdate event … #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mAxYoLo01
Copy link
Contributor

@mAxYoLo01 mAxYoLo01 commented Aug 24, 2023

…dispatching

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

As provided on the support server, updating the application command permissions will result in an error being thrown (even without listening to the event):

Traceback (most recent call last):
  File ".\Python311\Lib\site-packages\interactions\api\events\processors\integrations.py", line 35, in _raw_application_command_permissions_update
    self.dispatch(events.ApplicationCommandPermissionsUpdate(guild, perms))
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: ApplicationCommandPermissionsUpdate.__init__() missing 1 required positional argument: 'application_id'

This PR adds the missing event parameter.

Changes

Related Issues

Test Scenarios

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@silasary silasary merged commit 4283a96 into interactions-py:unstable Aug 24, 2023
@mAxYoLo01 mAxYoLo01 deleted the fix-app-commands-update branch August 24, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants