refactor!: Change type of permissions attrs to Permissions
#1209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damego
requested review from
AstreaTSS,
B1ue-Dev,
Catalyst4222,
FayeDel and
Toricane
Contributor
|
Time to test it again with my /channel lock command after ages. |
Contributor
|
Worked. Approved. |
B1ue-Dev
approved these changes
Dec 22, 2022
i0bs
approved these changes
Dec 22, 2022
Member
Author
|
i0 approved this pr, so I merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull request changes the type of
permissionsattribute of the most dataclasses toPermissionstype. Case when you can't change perms forOverwriteAdditionally fixes wrong check for
typeparameter inChannel.add_permission_overwrite.Checklist
pre-commitcode linter has been run over all edited files to ensure the code is linted.3.8.6and higher.I've made this pull request: (check all that apply)
This is: