Skip to content

refactor!: rename outdated channel type names to new #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 20, 2022
Merged

refactor!: rename outdated channel type names to new #1024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e636d4e
Merge pull request #959 from interactions-py/unstable
FayeDel Jul 24, 2022
53407b1
Merge pull request #985 from interactions-py/unstable
FayeDel Jul 30, 2022
7819ffc
Merge pull request #1001 from interactions-py/unstable
FayeDel Aug 10, 2022
c62c8d8
refactor!: Rename outdated channel type names to new
Damego Aug 20, 2022
8b5c8c4
refactor: change types in code
Damego Aug 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions interactions/api/models/channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ class ChannelType(IntEnum):
GUILD_VOICE = 2
GROUP_DM = 3
GUILD_CATEGORY = 4
GUILD_NEWS = 5
GUILD_ANNOUNCEMENT = 5
GUILD_STORE = 6
GUILD_NEWS_THREAD = 10
GUILD_PUBLIC_THREAD = 11
GUILD_PRIVATE_THREAD = 12
ANNOUNCEMENT_THREAD = 10
PUBLIC_THREAD = 11
PRIVATE_THREAD = 12
GUILD_STAGE_VOICE = 13
GUILD_FORUM = 15

Expand Down Expand Up @@ -966,7 +966,7 @@ def check_pinned(message):
async def create_thread(
self,
name: str,
type: Optional[ChannelType] = ChannelType.GUILD_PUBLIC_THREAD,
type: Optional[ChannelType] = ChannelType.PUBLIC_THREAD,
auto_archive_duration: Optional[int] = MISSING,
invitable: Optional[bool] = MISSING,
message_id: Optional[Union[int, Snowflake, "Message"]] = MISSING, # noqa
Expand Down Expand Up @@ -994,9 +994,9 @@ async def create_thread(
if not self._client:
raise LibraryException(code=13)
if type not in [
ChannelType.GUILD_NEWS_THREAD,
ChannelType.GUILD_PUBLIC_THREAD,
ChannelType.GUILD_PRIVATE_THREAD,
ChannelType.ANNOUNCEMENT_THREAD,
ChannelType.PUBLIC_THREAD,
ChannelType.PRIVATE_THREAD,
]:
raise LibraryException(message="type must be a thread type!", code=12)

Expand Down
14 changes: 7 additions & 7 deletions interactions/api/models/guild.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,7 +724,7 @@ async def create_thread(
self,
name: str,
channel_id: Union[int, Snowflake, Channel],
type: Optional[ChannelType] = ChannelType.GUILD_PUBLIC_THREAD,
type: Optional[ChannelType] = ChannelType.PUBLIC_THREAD,
auto_archive_duration: Optional[int] = MISSING,
invitable: Optional[bool] = MISSING,
message_id: Optional[Union[int, Snowflake, "Message"]] = MISSING,
Expand Down Expand Up @@ -754,9 +754,9 @@ async def create_thread(
if not self._client:
raise LibraryException(code=13)
if type not in [
ChannelType.GUILD_NEWS_THREAD,
ChannelType.GUILD_PUBLIC_THREAD,
ChannelType.GUILD_PRIVATE_THREAD,
ChannelType.ANNOUNCEMENT_THREAD,
ChannelType.PUBLIC_THREAD,
ChannelType.PRIVATE_THREAD,
]:
raise LibraryException(message="type must be a thread type!", code=12)

Expand Down Expand Up @@ -838,9 +838,9 @@ async def create_channel(
)

if type in [
ChannelType.GUILD_NEWS_THREAD,
ChannelType.GUILD_PUBLIC_THREAD,
ChannelType.GUILD_PRIVATE_THREAD,
ChannelType.ANNOUNCEMENT_THREAD,
ChannelType.PUBLIC_THREAD,
ChannelType.PRIVATE_THREAD,
]:
raise LibraryException(
message="Please use `create_thread` for creating threads!", code=12
Expand Down