Revert "Remove clang::optnone attribute for IgammaFunctor (#2351)" #2454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0c85351.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request reverts a previous commit that removed the clang::optnone attribute from IgammaFunctor. The revert restores the attribute and consolidates the IgammaFunctor and IgammacFunctor structures back into a single parameterized IgammaFunctor.
Key changes:
- Re-adds the
[[clang::optnone]]attribute to theIgammaFunctor::operator() - Merges
IgammacFunctorback intoIgammaFunctorwith a boolean parameter to control behavior - Updates kernel calls to pass the appropriate boolean flag
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CuiYifeng
approved these changes
Dec 4, 2025
Contributor
|
To quickly fix regression in #2452. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0c85351.