Enable FP8 concat_xpu and where_xpu #2152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yucai-intel
changed the title
yucai-intel
changed the title
Contributor
Author
|
torch.cat() float8 UT |
Contributor
Author
|
torch.whehe() float8 UT |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables FP8 (float8) dtype support for the concat_xpu and where_xpu operations by updating the kernel dispatchers and adding comprehensive regression tests.
- Updates
where_kernelto useAT_DISPATCH_V2macro with FP8 dtype support - Adds FP8 dtype support to
cat_out_kerneldispatcher - Adds regression tests for
torch.where()andtorch.cat()with FP8 dtypes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ATen/native/xpu/sycl/TensorCompareKernels.cpp | Updates where_kernel to use AT_DISPATCH_V2 macro and adds FP8 dtype support |
| src/ATen/native/xpu/sycl/Shape.cpp | Adds FP8 dtype support to cat_out_kernel dispatcher |
| test/regressions/test_where.py | Adds comprehensive regression tests for torch.where() with FP8 dtypes |
| test/regressions/test_cat.py | Adds regression tests for torch.cat() with FP8 dtypes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
CuiYifeng
approved these changes
Oct 31, 2025
Contributor
CuiYifeng
left a comment
CuiYifeng
left a comment
There was a problem hiding this comment.
The main part of this PR looks good to me.
chunhuanMeng
approved these changes
Nov 3, 2025
RUIJIEZHONG66166
pushed a commit
that referenced
this pull request
Nov 4, 2025
To solve #2207 This PR adds FP8 data types support for `torch.cat` and `torch.where` on XPU backend. --------- Co-authored-by: Cui, Yifeng <[email protected]> Co-authored-by: Copilot <[email protected]>
wincent8
pushed a commit
that referenced
this pull request
Nov 5, 2025
To solve #2207 This PR adds FP8 data types support for `torch.cat` and `torch.where` on XPU backend. --------- Co-authored-by: Cui, Yifeng <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve #2207
This PR adds FP8 data types support for
torch.catandtorch.whereon XPU backend.