[SYCL-TLA] Enable SYCL-TLA build #2030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuFinch
force-pushed
the
lfq/cutlass
branch
from
8b015d5 to
4ae8003
Compare
LuFinch
force-pushed
the
lfq/cutlass
branch
6 times, most recently
from
aa10375 to
e9800af
Compare
LuFinch
changed the title
LuFinch
changed the title
guangyey
reviewed
Oct 21, 2025
guangyey
reviewed
Oct 21, 2025
guangyey
reviewed
Oct 21, 2025
guangyey
reviewed
Oct 22, 2025
Contributor
Author
|
@fengyuan14 @EikanWang Could you help review and give some comments? |
EikanWang
approved these changes
Nov 7, 2025
guangyey
approved these changes
Nov 7, 2025
Contributor
Author
|
@EikanWang @guangyey Can we merge this PR? |
Contributor
|
Of course, let's move forward. We can apply a minor fix if needed. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (3)
cmake/BuildFlags.cmake:1
- Removed line that defines __INTEL_LLVM_COMPILER_VERSION. This flag may be required by code that checks the compiler version. If this removal is intentional, ensure that no code depends on this definition.
# Setup building flags for SYCL device and host codes.
cmake/BuildFlags.cmake:1
- This comment line was removed but the related code logic immediately following it remains unchanged. The comment should be preserved to document the FP64 conversion emulation logic for DG2/ATS-M targets.
# Setup building flags for SYCL device and host codes.
cmake/BuildFlags.cmake:1
- Removed initialization of SYCL_flags variable. This variable is no longer used after renaming to SYCL_COMPILE_FLAGS, but verify that no other code depends on SYCL_flags being defined.
# Setup building flags for SYCL device and host codes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2025
This PR moves the sycltla kernels in pytorch/pytorch#167056 into torch-xpu-ops. This PR is based on #2030. When the build PR merge, I will rebase this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to enable SYCL-TLA build in torch-xpu-ops so that we can test SYCL-TLA kernels' accuracy/performance in Pytorch when SDPA/GEMM kernels are ready.
After discussion with Eikan, we decided to put build logic in torch-xpu-ops while put kernels source code in Pytorch in-tree. Please put your SYCL-TLA kernel source code in Pytorch and set its path as part of
ATen_XPU_SYCLTLA_SRCSintorch-xpu-ops/src/ATen/CMakeLists.txt.Since SYCL-TLA has different compilation options compared with normal SYCL kernels in torch-xpu-ops, I make the logic in
cmake/BuildFlags.cmakeas a macro so that I can reuse the common compilation options.Since there is not a determined plan of how to import sycl-tla repo, I git clone the main branch in cmake for debug convinence. We can pin commit after sycl-tla has first release tag
Depend on g++ upgrading to gcc13, otherwise the sycltla kernel won't build