10 2 23 update #23
Merged
10 2 23 update #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update
mandalrajiv
suggested changes
Oct 4, 2023
examples/gen-ai-fastchat/README.md
Outdated
| 1. As mentioned above, **wait ~10 minutes** for the Recipe to download/install FastChat and the LLM model before continuing | ||
| 2. SSH into newly created AWS EC2 instance. | ||
| 3. The terraform module creates a key pair and adds the public key to the EC2 instance. It keeps the private key in the same folder from where the **terraform apply** was run. | ||
| 3. The terraform module creates a key pair and adds the public key to the EC2 instance. It keeps the private key in the same folder from where the **terraform apply** was run. (tf.private) |
There was a problem hiding this comment.
I think the filename is tfkey.private
There was a problem hiding this comment.
i updated that. After Talking to Lucas he wants me to write the Demo for AWS Cloudshell and see if we can simplify the instructions. I cant test until the module is updated with the AMI code changes.
examples/gen-ai-fastchat/README.md
Outdated
| 7. Your app will be proxied through gradio. See https://xxxxxxx.gradio.live URL that is generated during the run_demo.sh script execution. | ||
| 8. Open a browser and put the gradio url referenced in the prior step | ||
| 7. Now you can access the Fastchat by opening your browser and entering the following URL "http://<yourpublicip>:7860. | ||
| 8. Now you can enter your message or question in the chat prompt to see the Fastchat in action? |
There was a problem hiding this comment.
? mark may not be needed at the end since this is not a question.
There was a problem hiding this comment.
rewriting the demo piece to use Cloudshell
mandalrajiv
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing AMI code from the example for genai fast chat
updated Readme as well to be more clear on running the module