Remove of use of volatile and make memory allocation only for the lif… #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etime of a function that needs it - Do not use volatile for variables that will not be modified in a way the compiler cannot detect - Make the buffer used for topologyEntry structures allocated and freed when topology is being built, rather than being allocated for the lifetime of the driver load - Change macOS TopologyEntry struct to use int rather than uint, which is consistent with the other platforms in this project, as well as macOS's functions. - Instead of detecting at run time how big of a buffer we will need when issuing a sysctl, always use 4 bytes, which is specified in the docs and examples in kernel source code (see /usr/include/sys/sysctl.h)
nealsid
deleted the
client-build-and-topology-structure-mismatch-build-topology-stack-allocation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…etime of a function that needs it
Do not use volatile for variables that will not be modified in a way the compiler cannot detect
Make the buffer used for topologyEntry structures allocated and freed when topology is being built, rather than being allocated for the lifetime of the driver load
Change macOS TopologyEntry struct to use int rather than uint, which is consistent with the other platforms in this project, as well as macOS's functions.
Instead of detecting at run time how big of a buffer we will need when issuing a sysctl, always use 4 bytes, which is specified in the docs and examples in kernel source code (see /usr/include/sys/sysctl.h)