This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Misc fixes for darwin and android compilation on darwin #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 29, 2015 11:26
The code was using a hack to export headers only through a empty lib. This trick does not work on darwin hosts. This patch remove this hack and use the standard export C include dir. Change-Id: I34a69a6f66479b3a499efc4a648c43f022e1c472 Signed-off-by: Sebastien Gonzalve <[email protected]>
Pathes were hardcoded to linux which make compilation fail on MacOs. This patch gets the correct host build arch to fix compilation under MacOSx. Change-Id: Ie49d179cf1e7a54fa862f8b2f0996d7945884b96 Signed-off-by: Sebastien Gonzalve <[email protected]>
Those signals are useless and causes problems on darwin (BSD) compilation. Actually on recv, the flag is ignored on Linux, and on send, it should not be necessary if we do not write on a closed socket. Thus patch thus removes the flags and close the socket on error.
The lib in prebuild/darwin-x86 is in fact a 64bit lib and link fails. This patch make the host binary use the host python to link (this is quite wrong as the version may not be compatible with the android swig version Change-Id: Ic6ed36a498904e082c1c60f05cc54827ca6ea705 Signed-off-by: Sebastien Gonzalve <[email protected]>
Contributor
Author
Contributor
There was a problem hiding this comment.
no dummy value on darwin, only linux's python-config is broken?
Contributor
|
Are you sure a SIGPIPE can be received ? I though that it was when reading a file descriptor after receiving EOF ? |
Closed
Contributor
|
Took owneship in #131 of this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and workarounds for darwin, mostly related to android. Closes #39.