Use absolute paths for libraries loaded with LOAD_WITH_ALTERED_SEARCH_PATH #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MayureshV1
approved these changes
Mar 3, 2025
MayureshV1
left a comment
MayureshV1
left a comment
There was a problem hiding this comment.
Verified. Resolves the failure we were seeing while running tests with --build_wheel enabled.
|
@sfatimar , Can we please merge to ovep-develop and make sure it goes through nightly validation. |
Author
@MayureshV1 I think we should propose this change to MSFT and have them make the final change. They may want to make the change in onnxruntime source to handle more cases where relative path was passed to load the library. |
|
LGTM |
ankitm3k
pushed a commit
that referenced
this pull request
Apr 1, 2025
ankitm3k
pushed a commit
that referenced
this pull request
Apr 1, 2025
ankitm3k
pushed a commit
that referenced
this pull request
Apr 2, 2025
ankitm3k
pushed a commit
that referenced
this pull request
Apr 4, 2025
ankitm3k
pushed a commit
that referenced
this pull request
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LoadLibrary behavior with relative paths when LOAD_WITH_ALTERED_SEARCH_PATH is used is unknown
Motivation and Context
Fixes the failures seen while running onnxruntime_test_python