-
Notifications
You must be signed in to change notification settings - Fork 10
add github actions CI workflow #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Are you sure that you don't have DBus on you server? The graceful shutdown uses "ScheduleShutdown" from "org.freedesktop.login1.Manager". |
7186b22 to
e4abc4d
Compare
|
@ausyskin, I was finally be able to pick this up again. You are correct, Debian 11 server actually has dbus running. Thanks for questioning that :-) I do not use NM nor CM. I'll be using the netlink flavor of lms. It would be nice to have a comparison list of features between those three documented in the readme. I've redid the PR to use docker to build the binaries for debian 11 and ubuntu 20.04. Because those two distributions use different dependencies versions, and that makes the .deb file incompatible between them. I'm not sure what to do with the You can see the example GitHub Actions produced Artifacts at https://github.com/rgl/lms/actions. The .deb files will end up with a different name, depending on the distribution (e.g. Let me known what you think and how to proceed from here. |
e4abc4d to
89e2983
Compare
|
I've updated this PR to also generate the Ubuntu 22.04 deb package. I've documented how this can be installed in https://github.com/rgl/lms-binaries. There is a problem with the packages, they do not include their dependencies. This means, its awkward to install the lms package, because the user/admin must somehow known what dependencies he has to install. Is not having the .deb package have a |
c309b1f to
47a54a4
Compare
47a54a4 to
5962e57
Compare
5962e57 to
9882793
Compare
|
I think they are limited by default to 90 days, but I'm good with any retention period. My main goal with this action is to ensure that any code change can still build the code and generate the package for Debian/Ubuntu. |
This adds an CI workflow that builds the debian package in a Ubuntu 18.04 CI node.
You can see this in action at https://github.com/rgl/lms/actions.
I've installed the .deb package (available to download at the workflow home page Artifacts link) in a Ubuntu 20.04 machine, and I was able to use MeshCommander to gracefully shutdown the OS/machine :-)
I have one doubt, that machine is running Ubuntu Server, that by default, does not include/needs dbus, and a such, understandingly, the lms service complains that it cannot access dbus (but seems to work fine despite that error) with:
Is there a way to build lms with all the supported backends (dbus, network manager, etc) and let the administrator choose which ones to use? that is, move that decision to runtime instead of build time? does it make sense to have this build option?
I'm asking because, like it is, is going to be a hard to package this software; or we have to build different packages for each of the options combinations (e.g. lms-dbus.deb, lms-nm.deb, etc).