Skip to content

Conversation

@aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented Jun 8, 2023

It's generally good when the task doesn't leave any leftovers after itself. That becomes even more important when using self-hosted runners where leftovers aren't cleared by the container destruction (if one is used at all).

This is also kind of related to the root/actions/checkout/lint issue that (I believe with about 90% confidence) is not caused by the actions/checkout. Instead, it's the difference under which user the job is executed due to the containers usage.

In a nutshell, I'm trying to move our ubuntu-* tasks onto local runners and this PR is one of several change I'm making/made. I'm currently using the cuda runner because we can get by with tasks not cleaning after themselves as no real jobs are being scheduled there. However, I'm working on implementing all the necessary cleanups so that we can schedule them on any Linux runner and returning the cuda runner back to the pool where we can run CUDA testing on it.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner June 8, 2023 16:04
@bader
Copy link
Contributor

bader commented Jun 8, 2023

Any description with the explanation about why this change is needed?

@aelovikov-intel
Copy link
Contributor Author

Tested manually in https://github.com/intel/llvm/actions/runs/5213273226/jobs/9408036060 via observing filesystem on the self-hosted runner where the job is executed. Note that manual cleanup will be needed after this is merged in because all other current tasks run the job without cleanup and leave files after themselves.

@aelovikov-intel
Copy link
Contributor Author

Any description with the explanation about why this change is needed?

It's generally good when the task doesn't leave any leftovers after itself.

This is also kind of related to the root/actions/checkout/lint issue that (I believe with about 90% confidence) is not caused by the actions/checkout. Instead, it's the difference under which user the job is executed due to the containers usage.

In a nutshell, I'm trying to move our ubuntu-* tasks onto local runners. I'm currently using the cuda runner because we can get by with tasks not cleaning after themselves as no real jobs are being scheduled there. However, I'm working on implementing all the necessary cleanups so that we can schedule them on any Linux runner and returning the cuda runner back to the pool where we can run CUDA testing on it.

@bader
Copy link
Contributor

bader commented Jun 8, 2023

Any description with the explanation about why this change is needed?

It's generally good when the task doesn't leave any leftovers after itself.

This is also kind of related to the root/actions/checkout/lint issue that (I believe with about 90% confidence) is not caused by the actions/checkout. Instead, it's the difference under which user the job is executed due to the containers usage.

In a nutshell, I'm trying to move our ubuntu-* tasks onto local runners. I'm currently using the cuda runner because we can get by with tasks not cleaning after themselves as no real jobs are being scheduled there. However, I'm working on implementing all the necessary cleanups so that we can schedule them on any Linux runner and returning the cuda runner back to the pool where we can run CUDA testing on it.

Please, put this text to PR description.

@aelovikov-intel aelovikov-intel temporarily deployed to aws June 8, 2023 17:09 — with GitHub Actions Inactive
@aelovikov-intel
Copy link
Contributor Author

Please, put this text to PR description.

Done, with some minor additions.

@aelovikov-intel aelovikov-intel temporarily deployed to aws June 8, 2023 18:48 — with GitHub Actions Inactive
@aelovikov-intel
Copy link
Contributor Author

@bader , do you expect anything else from me here?

@bader
Copy link
Contributor

bader commented Jun 9, 2023

@bader , do you expect anything else from me here?

This looks fine, but we should be consistent in applying our rules. Make sure the same logic is applied to #9797 when it's ready for review.

@aelovikov-intel aelovikov-intel merged commit fbbfe6d into intel:sycl Jun 9, 2023
@aelovikov-intel aelovikov-intel deleted the gen-matrix-cleanup branch June 9, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants