-
Notifications
You must be signed in to change notification settings - Fork 801
[CI] Add cleanup for workflows/sycl_gen_test_matrix.yml #9796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Any description with the explanation about why this change is needed? |
|
Tested manually in https://github.com/intel/llvm/actions/runs/5213273226/jobs/9408036060 via observing filesystem on the self-hosted runner where the job is executed. Note that manual cleanup will be needed after this is merged in because all other current tasks run the job without cleanup and leave files after themselves. |
It's generally good when the task doesn't leave any leftovers after itself. This is also kind of related to the In a nutshell, I'm trying to move our |
Please, put this text to PR description. |
Done, with some minor additions. |
|
@bader , do you expect anything else from me here? |
It's generally good when the task doesn't leave any leftovers after itself. That becomes even more important when using self-hosted runners where leftovers aren't cleared by the container destruction (if one is used at all).
This is also kind of related to the root/actions/checkout/lint issue that (I believe with about 90% confidence) is not caused by the actions/checkout. Instead, it's the difference under which user the job is executed due to the containers usage.
In a nutshell, I'm trying to move our ubuntu-* tasks onto local runners and this PR is one of several change I'm making/made. I'm currently using the cuda runner because we can get by with tasks not cleaning after themselves as no real jobs are being scheduled there. However, I'm working on implementing all the necessary cleanups so that we can schedule them on any Linux runner and returning the cuda runner back to the pool where we can run CUDA testing on it.