Skip to content

[SYCL] [NFC] Allow for buildability of LLVMASFixer as shared lib #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SYCL] [NFC] Allow for buildability of LLVMASFixer as shared lib #897

wants to merge 1 commit into from

Conversation

s-kanaev
Copy link
Contributor

@s-kanaev s-kanaev commented Dec 2, 2019

No description provided.

@s-kanaev s-kanaev requested a review from vladimirlaz December 2, 2019 11:20
bader
bader requested changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library is going to be removed by #893.
I see no point in committing this change.

@s-kanaev
Copy link
Contributor Author

s-kanaev commented Dec 2, 2019

This library is going to be removed by #893.

Oh, OK.

@s-kanaev s-kanaev closed this Dec 2, 2019
@s-kanaev s-kanaev deleted the fix-build-issue-shared-libs branch December 2, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader requested changes

@vladimirlaz vladimirlaz Awaiting requested review from vladimirlaz

Assignees

@vladimirlaz vladimirlaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-kanaev @bader @vladimirlaz