[SYCL] Remove ASFixer and DISABLE_INFER_AS support #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keryell, FYI. |
It's not needed anymore in the triSYCL project (we still call the pass, but it's redundant and not required), I swapped it to the recommended method a couple of months ago and left a message here: #361 I should have probably been more clear and stated we no longer need the ASFixer/Env variable at the time though... sorry about that. #361 can probably be closed as well. |
romanovvlad
force-pushed
the
private/vromanov/RemoveASFixer
branch
from
53aea76 to
2a39d78
Compare
Fznamznon
reviewed
Dec 2, 2019
Signed-off-by: Vlad Romanov <[email protected]>
asavonic
suggested changes
Dec 2, 2019
| @@ -1,201 +0,0 @@ | |||
| // RUN: DISABLE_INFER_AS=1 %clang_cc1 -triple spir64-unknown-linux-sycldevice -std=c++11 -fsycl-is-device -disable-llvm-passes -emit-llvm -x c++ %s -o - | opt -asfix -S -o - | FileCheck %s --check-prefixes CHECK,CHECK-OLD | |||
| // RUN: %clang_cc1 -triple spir64-unknown-linux-sycldevice -std=c++11 -fsycl-is-device -disable-llvm-passes -emit-llvm -x c++ %s -o - | opt -asfix -S -o - | FileCheck %s --check-prefixes CHECK,CHECK-NEW | |||
There was a problem hiding this comment.
Keep the CHECK-NEW lines here.
Signed-off-by: Vlad Romanov <[email protected]>
romanovvlad
force-pushed
the
private/vromanov/RemoveASFixer
branch
from
2a39d78 to
d5a1430
Compare
asavonic
previously approved these changes
Dec 2, 2019
Signed-off-by: Vlad Romanov <[email protected]>
asavonic
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vlad Romanov [email protected]