Skip to content

[SYCL] Remove ASFixer and DISABLE_INFER_AS support #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2019

Conversation

romanovvlad
Copy link
Contributor

Signed-off-by: Vlad Romanov [email protected]

@bader
Copy link
Contributor

bader commented Nov 30, 2019

@keryell, FYI.

@agozillon
Copy link
Contributor

@keryell, FYI.

It's not needed anymore in the triSYCL project (we still call the pass, but it's redundant and not required), I swapped it to the recommended method a couple of months ago and left a message here: #361 I should have probably been more clear and stated we no longer need the ASFixer/Env variable at the time though... sorry about that. #361 can probably be closed as well.

@@ -1,201 +0,0 @@
// RUN: DISABLE_INFER_AS=1 %clang_cc1 -triple spir64-unknown-linux-sycldevice -std=c++11 -fsycl-is-device -disable-llvm-passes -emit-llvm -x c++ %s -o - | opt -asfix -S -o - | FileCheck %s --check-prefixes CHECK,CHECK-OLD
// RUN: %clang_cc1 -triple spir64-unknown-linux-sycldevice -std=c++11 -fsycl-is-device -disable-llvm-passes -emit-llvm -x c++ %s -o - | opt -asfix -S -o - | FileCheck %s --check-prefixes CHECK,CHECK-NEW
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the CHECK-NEW lines here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@romanovvlad romanovvlad force-pushed the private/vromanov/RemoveASFixer branch from 2a39d78 to d5a1430 Compare December 2, 2019 14:45
@romanovvlad romanovvlad marked this pull request as ready for review December 2, 2019 15:44
Fznamznon
Fznamznon previously approved these changes Dec 2, 2019
Copy link
Contributor

@Fznamznon Fznamznon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

asavonic
asavonic previously approved these changes Dec 2, 2019
@romanovvlad romanovvlad dismissed stale reviews from asavonic and Fznamznon via dea4b0e December 2, 2019 19:50
@romanovvlad romanovvlad requested a review from asavonic December 3, 2019 10:52
@romanovvlad romanovvlad merged commit 59f4592 into intel:sycl Dec 3, 2019
@romanovvlad romanovvlad deleted the private/vromanov/RemoveASFixer branch December 3, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants