-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] Remove ASFixer and DISABLE_INFER_AS support #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Remove ASFixer and DISABLE_INFER_AS support #893
Conversation
@keryell, FYI. |
It's not needed anymore in the triSYCL project (we still call the pass, but it's redundant and not required), I swapped it to the recommended method a couple of months ago and left a message here: #361 I should have probably been more clear and stated we no longer need the ASFixer/Env variable at the time though... sorry about that. #361 can probably be closed as well. |
53aea76
to
2a39d78
Compare
Signed-off-by: Vlad Romanov <[email protected]>
@@ -1,201 +0,0 @@ | |||
// RUN: DISABLE_INFER_AS=1 %clang_cc1 -triple spir64-unknown-linux-sycldevice -std=c++11 -fsycl-is-device -disable-llvm-passes -emit-llvm -x c++ %s -o - | opt -asfix -S -o - | FileCheck %s --check-prefixes CHECK,CHECK-OLD | |||
// RUN: %clang_cc1 -triple spir64-unknown-linux-sycldevice -std=c++11 -fsycl-is-device -disable-llvm-passes -emit-llvm -x c++ %s -o - | opt -asfix -S -o - | FileCheck %s --check-prefixes CHECK,CHECK-NEW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the CHECK-NEW lines here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Signed-off-by: Vlad Romanov <[email protected]>
2a39d78
to
d5a1430
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Vlad Romanov <[email protected]>
Signed-off-by: Vlad Romanov [email protected]