Skip to content

Conversation

@jcranmer-intel
Copy link
Contributor

No description provided.

@jcranmer-intel jcranmer-intel requested a review from a team as a code owner April 5, 2023 17:27
@jcranmer-intel
Copy link
Contributor Author

This adds the changes in

#define IMAGE_TYPE(ImgType, Id, SingletonId, Access, Suffix) \
case BuiltinType::Sampled##Id: \
return llvm::PointerType::get( \
llvm::StructType::create(Ctx, "spirv.SampledImage." #ImgType \
"_" #Suffix "_t"), \
AddrSpc);
#define IMAGE_WRITE_TYPE(Type, Id, Ext)
#define IMAGE_READ_WRITE_TYPE(Type, Id, Ext)
#include "clang/Basic/OpenCLImageTypes.def"
to the SPIR-V target extension type generation.

@smanna12
Copy link
Contributor

smanna12 commented Apr 5, 2023

@jcranmer-intel Do you have any test for this change?

@jcranmer-intel
Copy link
Contributor Author

@jcranmer-intel Do you have any test for this change?

No, I haven't prepared any specific tests for this change yet.

@jcranmer-intel
Copy link
Contributor Author

Hi, what's blocking merging this PR at this point?

@dm-vodopyanov
Copy link
Contributor

Hi, what's blocking merging this PR at this point?

@jcranmer-intel please fix clang-format issue, SYCL Pre Commit / lint (pull_request_target) is failing.

@jcranmer-intel
Copy link
Contributor Author

Hi, what's blocking merging this PR at this point?

@jcranmer-intel please fix clang-format issue, SYCL Pre Commit / lint (pull_request_target) is failing.

In this case, I believe the existing change is correct formatting, and the clang-format suggested fix would cause the code to become incorrectly formatted--it moves the case statements left by one indentation level, before the switch statements.

@dm-vodopyanov
Copy link
Contributor

Hi, what's blocking merging this PR at this point?

@jcranmer-intel please fix clang-format issue, SYCL Pre Commit / lint (pull_request_target) is failing.

In this case, I believe the existing change is correct formatting, and the clang-format suggested fix would cause the code to become incorrectly formatted--it moves the case statements left by one indentation level, before the switch statements.

If clang-format suggests wrong formatting for some block of code, please wrap this block with

// clang-format off
...
// clang-format on

@jcranmer-intel jcranmer-intel temporarily deployed to aws April 18, 2023 23:07 — with GitHub Actions Inactive
@jcranmer-intel jcranmer-intel temporarily deployed to aws April 18, 2023 23:08 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov merged commit f0b71e1 into intel:sycl Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants