-
Notifications
You must be signed in to change notification settings - Fork 800
[OpaquePtr] Emit target extension types for sampled images for SPIR-V. #8957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This adds the changes in llvm/clang/lib/CodeGen/CGOpenCLRuntime.cpp Lines 73 to 81 in d5a2731
|
|
@jcranmer-intel Do you have any test for this change? |
No, I haven't prepared any specific tests for this change yet. |
|
Hi, what's blocking merging this PR at this point? |
@jcranmer-intel please fix clang-format issue, |
In this case, I believe the existing change is correct formatting, and the clang-format suggested fix would cause the code to become incorrectly formatted--it moves the case statements left by one indentation level, before the switch statements. |
If clang-format suggests wrong formatting for some block of code, please wrap this block with |
No description provided.