[SYCL] Fix and re-enable some kernel-and-program/Cache.cpp unit tests. #8121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These unit tests were disabled when the sycl::program class was removed. I have modified some of these unit tests to use kernel_bundles instead.
steffenlarsen
approved these changes
Feb 1, 2023
bader
changed the title
|
@intel/llvm-gatekeepers The PR is ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These unit tests were disabled when the sycl::program class was removed in #6666
I have modified some of these unit tests to use kernel_bundles instead of sycl::program.
I was not able to modify and re-enable all the unit tests in Cache.cpp file because some of the older test cases were using APIs like sycl::program.build_with_source (or compile_with_source) and, as far as I am aware of it, there is no kernel_bundle API(s) equivalent to sycl::program.build_with_source.