Skip to content

[SYCL] Allow unittests to use drainThreadPool method on Win #8006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2023
Merged

[SYCL] Allow unittests to use drainThreadPool method on Win #8006

merged 1 commit into from
Jan 13, 2023

Conversation

KseniyaTikhomirova
Copy link
Contributor

Signed-off-by: Tikhomirova, Kseniya [email protected]

@KseniyaTikhomirova KseniyaTikhomirova requested a review from a team as a code owner January 13, 2023 13:32
@KseniyaTikhomirova KseniyaTikhomirova mentioned this pull request Jan 13, 2023
Merged
@KseniyaTikhomirova
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1462

@KseniyaTikhomirova KseniyaTikhomirova temporarily deployed to aws January 13, 2023 14:02 — with GitHub Actions Inactive
@KseniyaTikhomirova KseniyaTikhomirova temporarily deployed to aws January 13, 2023 14:53 — with GitHub Actions Inactive
@KseniyaTikhomirova
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1462

@KseniyaTikhomirova
Copy link
Contributor Author

llvm-test_suite linux failure is infrastructure issue. win passed

@bader
Copy link
Contributor

bader commented Jan 13, 2023

Why do you prefer /verify with instead of /testwin?

@KseniyaTikhomirova
Copy link
Contributor Author

Why do you prefer /verify with instead of /testwin?

It seems that it doen't run llvm-test_suite tests

@KseniyaTikhomirova
Copy link
Contributor Author

Why do you prefer /verify with instead of /testwin?

According to Chris #7908
"The "/testwin" directive only makes sure something is buildable on windows and the in-tree tests are run, but not the llvm-test-suite tests on Windows."

@bader
Copy link
Contributor

bader commented Jan 13, 2023 •
edited
Loading

Ah... I forgot that #7477 hasn't been merged yet.

@bader bader merged commit 7522787 into intel:sycl Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanovvlad romanovvlad romanovvlad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KseniyaTikhomirova @bader @romanovvlad