Skip to content

[SYCL][Reduction] Fix race condition in withAuxHandler #7563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2022
Merged

[SYCL][Reduction] Fix race condition in withAuxHandler #7563

merged 2 commits into from
Nov 29, 2022

Conversation

aelovikov-intel
Copy link
Contributor

No description provided.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner November 28, 2022 22:40
steffenlarsen
steffenlarsen approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but otherwise a good catch! 😄

This was referenced Nov 29, 2022
Merged
Merged
Merged
aelovikov-intel
aelovikov-intel commented Nov 29, 2022
View reviewed changes
@aelovikov-intel
Copy link
Contributor Author

Failures:
SYCL :: Basic/barrier_order.cpp - #7330

@steffenlarsen is addressing those three with his PRs:
SYCL :: BFloat16/bfloat16_builtins.cpp
SYCL :: Matrix/element_wise_wi_marray_legacy.cpp
SYCL :: Matrix/joint_matrix_tensorcores_legacy.cpp

@steffenlarsen steffenlarsen merged commit 8ebd912 into intel:sycl Nov 29, 2022
@aelovikov-intel aelovikov-intel deleted the reduction-race branch April 7, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aelovikov-intel @steffenlarsen