[SYCL] Fix get_pointer_device for cases with descendent devices #6719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking through context members alone when searching for a specific device isn't enough anymore since now descendent devices of context members can be used within that context as well. Change the logic to look for the device in the cache instead.
Contributor
Author
|
/verify with intel/llvm-test-suite#1232 |
Contributor
Author
|
@cperkinsintel Could you please review this one? |
Contributor
|
What do you mean by "descendent devices"? |
Contributor
Author
Subdevices, subsubdevices, etc. It's a term used in the spec: https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#descendent-device |
Contributor
Author
|
@cperkinsintel @intel/llvm-reviewers-runtime Gentle ping |
Contributor
Author
|
@intel/llvm-gatekeepers Could you please merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking through context members alone when searching for a specific device isn't enough anymore since now descendent devices of context members can be used within that context as well. Change the logic to look for the device in the cache instead.