[SYCL][Windows] Enable building lld by default on Windows #6701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Windows-Clang CMake module uses `lld-link` by default, so having lld built on windows is helpful for people wanting to build SYCL applications using CMake.
bader
reviewed
Sep 6, 2022
bader
previously approved these changes
Sep 6, 2022
sycl/CMakeLists.txt
Outdated
Comment on lines
386
to
387
| # Build and install lld as part of the sycl-toolchain if available | ||
| if(TARGET lld) |
Contributor
There was a problem hiding this comment.
I hope it works.
I thought about examining LLVM_ENABLE_PROJECTS value, but assuming that lld's project cmake files are parsed before this cmake file, this should work as well.
Contributor
Author
There was a problem hiding this comment.
Good point, I was under the incorrect assumptions that the target would need to already be defined for add_dependencies to work anyway, but it looks like add_dependencies still works even if the target is defined later, so I've replaced the conditions with your initial suggestion.
bader
approved these changes
Sep 6, 2022
aelovikov-intel
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows-Clang CMake module uses
lld-linkby default, sohaving lld built on windows is helpful for people wanting to build SYCL
applications using CMake.
Related to: #6026